Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

clusterresolver: remove redundant tests #6388

Merged
merged 2 commits into from
Jun 22, 2023
Merged

clusterresolver: remove redundant tests #6388

merged 2 commits into from
Jun 22, 2023

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Jun 22, 2023 •
edited
Loading

This PR removes two tests which are redundant:

  • TestClientWatchEDS is already covered by an e2e test TestEDS_ClusterResourceUpdates
  • TestFallbackToDNS is covered by an e2e test TestAggregateCluster_BadEDS_BadDNS

#resource-agnostic-xdsclient-api

RELEASE NOTES: none

@easwars easwars requested a review from zasweq June 22, 2023 03:56
@easwars easwars added this to the 1.57 Release milestone Jun 22, 2023
zasweq
zasweq approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I noticed yesterday writing tests for the server feature we have a lot of mocks that verify calls into mocks.

@easwars
Copy link
Contributor Author

easwars commented Jun 22, 2023

LGTM. I noticed yesterday writing tests for the server feature we have a lot of mocks that verify calls into mocks.

Is that related in any way to this PR?

@easwars easwars merged commit f24b4c7 into grpc:master Jun 22, 2023
1 check passed
@easwars easwars deleted the clusterresolver_test_cleanup_part_1 branch June 22, 2023 21:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@zasweq zasweq zasweq approved these changes

Assignees

@zasweq zasweq

Labels
Type: Testing
Projects
None yet
Milestone
1.57 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@easwars @zasweq