Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: speed up TestServiceConfigTimeoutTD from 1.8s to 0.03s #6571

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Aug 22, 2023

I made this test significantly slower by changing 1ns into 100ms when I made #6506. And 100ms*2 doesn't seem to bad, but this is multiplied by the number of "test environments" we have (6), so it does add up quickly.

RELEASE NOTES: None

@dfawley dfawley added this to the 1.58 Release milestone Aug 22, 2023
@dfawley dfawley requested a review from arvindbr8 August 22, 2023 23:37
@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 Aug 22, 2023
@dfawley dfawley merged commit 7d35b8e into grpc:master Aug 23, 2023
1 check passed
@dfawley dfawley deleted the testspdup branch August 23, 2023 15:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants