Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

grpclb: some minor cleanups #6634

Merged
merged 5 commits into from
Sep 15, 2023
Merged

grpclb: some minor cleanups #6634

merged 5 commits into from
Sep 15, 2023

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Sep 14, 2023

  • use base.NewErrPicker instead of implementing an error picker
  • use proto.Equal directly without using cmp.Equal
  • use a prefix logger and cleanup log statements

RELEASE NOTES: none

@easwars easwars requested a review from dfawley September 14, 2023 19:43
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Sep 14, 2023
@easwars easwars added this to the 1.59 Release milestone Sep 14, 2023
dfawley
dfawley approved these changes Sep 14, 2023
View reviewed changes
balancer/grpclb/grpclb.go Outdated
clientStats: newRPCStats(),
backoff: backoff.DefaultExponential, // TODO: make backoff configurable.
}
lb.logger = internalgrpclog.NewPrefixLogger(logger, fmt.Sprintf("grpclb %p] ", lb))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did an opening bracket get lost here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Fixed.

@dfawley dfawley assigned easwars and unassigned dfawley Sep 14, 2023
@easwars easwars assigned dfawley and unassigned easwars Sep 14, 2023
@dfawley dfawley assigned easwars and unassigned dfawley Sep 14, 2023
@easwars easwars merged commit 94d8074 into grpc:master Sep 15, 2023
1 check passed
@easwars easwars deleted the grpclb_cleanup_err_picker branch September 15, 2023 17:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@easwars easwars

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.59 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@easwars @dfawley