Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

resolver: remove ClientConn.NewServiceConfig #6784

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Nov 13, 2023

cc #6472

All dependencies checked do not use this method any longer. It has been deprecated for sufficient time.

RELEASE NOTES:

  • resolver: remove deprecated and experimental ClientConn.NewServiceConfig

@dfawley dfawley added the Type: API Change Breaking API changes (experimental APIs only!) label Nov 13, 2023
@dfawley dfawley added this to the 1.60 Release milestone Nov 13, 2023
@dfawley dfawley requested a review from arvindbr8 November 13, 2023 22:02
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #6784 (09e1e0c) into master (8b17a4d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6784      +/-   ##
==========================================
- Coverage   83.47%   83.46%   -0.01%     
==========================================
  Files         285      285              
  Lines       30967    30950      -17     
==========================================
- Hits        25850    25833      -17     
+ Misses       4045     4044       -1     
- Partials     1072     1073       +1     
Files Coverage Δ
resolver/resolver.go 94.44% <ø> (ø)
resolver_conn_wrapper.go 94.82% <ø> (+10.85%) ⬆️
.../balancer/clusterresolver/resource_resolver_dns.go 65.59% <ø> (+1.38%) ⬆️

... and 22 files with indirect coverage changes

Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dfawley dfawley merged commit 8645f95 into grpc:master Nov 13, 2023
1 check passed
@dfawley dfawley deleted the newsvccfg branch December 4, 2023 22:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Type: API Change Breaking API changes (experimental APIs only!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants