client: further streamlining of Dial #6802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add newClient method that starts a client in idle mode. * Use newClient in DialContext. * Use default dial options as appropriate. * Stop cloning credentials unnecessarily. We never mutate them ourselves and a single copy is insufficient if some other LB policy ever mutates them.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6802 +/- ##
==========================================
+ Coverage 83.42% 83.60% +0.18%
==========================================
Files 285 285
Lines 30893 30883 -10
==========================================
+ Hits 25773 25821 +48
+ Misses 4048 4004 -44
+ Partials 1072 1058 -14
|
arvindbr8
approved these changes
Nov 15, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: n/a