Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

transport: Remove redundant if in handleGoAway #6930

Merged
merged 1 commit into from
Jan 23, 2024
Merged

transport: Remove redundant if in handleGoAway #6930

merged 1 commit into from
Jan 23, 2024

Conversation

narqo
Copy link
Contributor

@narqo narqo commented Jan 18, 2024 •
edited by arvindbr8
Loading

This PR fixes a typo in http2Client, removing the redundant checks in the handleGoAway

RELEASE NOTES: none

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 18, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: narqo / name: Vladimir Varankin (fe37859)

@narqo narqo force-pushed the transport-fix-typo branch from bd15a4f to fe37859 Compare January 18, 2024 19:29
@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited
Loading

Codecov Report

Merging #6930 (fe37859) into master (987df13) will increase coverage by 0.06%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6930      +/-   ##
==========================================
+ Coverage   83.66%   83.72%   +0.06%     
==========================================
  Files         287      287              
  Lines       30931    30930       -1     
==========================================
+ Hits        25879    25897      +18     
+ Misses       3987     3972      -15     
+ Partials     1065     1061       -4
Files Coverage Δ
internal/transport/http2_client.go 90.76% <100.00%> (-0.09%) ⬇️

... and 14 files with indirect coverage changes

@arvindbr8 arvindbr8 added the Type: Internal Cleanup Refactors, etc label Jan 23, 2024
@arvindbr8 arvindbr8 added this to the 1.61 Release milestone Jan 23, 2024
@zasweq zasweq changed the title transport: typo in handleGoAway transport: Remove redundant if in handleGoAway Jan 23, 2024
@zasweq zasweq merged commit 67e50be into grpc:master Jan 23, 2024
14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

@zasweq zasweq zasweq approved these changes

Assignees

@zasweq zasweq

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.61 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@narqo @arvindbr8 @zasweq