Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

xds/googlec2p: use xdstp names for LDS #6949

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Conversation

apolcyn
Copy link
Contributor

@apolcyn apolcyn commented Jan 30, 2024

As title.

Integration tests passing.

RELEASE NOTES:

  • xds/googlec2p: use xdstp names for LDS

@arvindbr8 arvindbr8 changed the title [google-c2p resolver] use xdstp names for lds xds/googlec2p: use xdstp names for LDS Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Merging #6949 (06e693d) into master (8d735f0) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 68.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6949      +/-   ##
==========================================
- Coverage   83.71%   83.69%   -0.02%     
==========================================
  Files         287      287              
  Lines       30926    30929       +3     
==========================================
- Hits        25889    25887       -2     
- Misses       3972     3976       +4     
- Partials     1065     1066       +1     
Files Coverage Δ
balancer/grpclb/grpclb.go 80.47% <ø> (ø)
balancer/grpclb/grpclb_remote_balancer.go 83.69% <ø> (ø)
balancer/rls/config.go 83.22% <100.00%> (ø)
encoding/proto/proto.go 62.50% <ø> (ø)
internal/binarylog/method_logger.go 87.31% <100.00%> (ø)
internal/binarylog/sink.go 11.42% <ø> (ø)
internal/pretty/pretty.go 57.89% <100.00%> (+15.78%) ⬆️
internal/status/status.go 90.52% <100.00%> (ø)
internal/transport/handler_server.go 85.91% <ø> (ø)
internal/transport/http2_server.go 89.56% <ø> (ø)
... and 15 more

... and 14 files with indirect coverage changes

@arvindbr8 arvindbr8 added the Type: Behavior Change Behavior changes not categorized as bugs label Jan 30, 2024
@arvindbr8 arvindbr8 added this to the 1.62 Release milestone Jan 30, 2024
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@arvindbr8 arvindbr8 merged commit 3aafa84 into grpc:master Jan 31, 2024
1 check passed
apolcyn added a commit to apolcyn/grpc-go that referenced this pull request Feb 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Type: Behavior Change Behavior changes not categorized as bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants