Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

gcp/observability: update stackdriver dependency to remove dep on prometheus #7008

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Feb 28, 2024

Stackdriver was never v1.0 and used a non-v1.0 version of prometheus, which moved/removed a package stackdriver was using. Stackdriver removed this dependency later, but the project is archived and didn't perform a release after removing the dependency, so we need to manually update it to an unreleased version.

cc @dashpole as FYI

RELEASE NOTES: none

@dfawley dfawley added the Type: Dependencies Updating/adding/removing dependencies label Feb 28, 2024
@dfawley dfawley added this to the 1.63 Release milestone Feb 28, 2024
@dfawley dfawley requested a review from arvindbr8 February 28, 2024 20:57
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Merging #7008 (19bf50a) into master (27c5d98) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 19bf50a differs from pull request most recent head 93c8d43. Consider uploading reports for the commit 93c8d43 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7008      +/-   ##
==========================================
+ Coverage   82.28%   82.32%   +0.04%     
==========================================
  Files         296      296              
  Lines       31464    31464              
==========================================
+ Hits        25890    25904      +14     
+ Misses       4503     4490      -13     
+ Partials     1071     1070       -1     

see 17 files with indirect coverage changes

@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 Feb 28, 2024
@dfawley dfawley merged commit e978e43 into grpc:master Feb 28, 2024
12 checks passed
@dfawley dfawley deleted the deps branch February 28, 2024 21:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Type: Dependencies Updating/adding/removing dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants