Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

experimental: re-split message/service pb imports #7011

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

arvindbr8
Copy link
Member

@arvindbr8 arvindbr8 commented Feb 28, 2024

In #6766, the double import was removed. This PR adds that back.

RELEASE NOTES: none

@arvindbr8 arvindbr8 added the Type: Internal Cleanup Refactors, etc label Feb 28, 2024
@arvindbr8 arvindbr8 added this to the 1.63 Release milestone Feb 28, 2024
@arvindbr8 arvindbr8 requested a review from dfawley February 28, 2024 22:28
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Merging #7011 (fb16355) into master (99ded5c) will increase coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7011      +/-   ##
==========================================
+ Coverage   82.33%   82.41%   +0.07%     
==========================================
  Files         296      296              
  Lines       31464    31464              
==========================================
+ Hits        25907    25930      +23     
+ Misses       4492     4470      -22     
+ Partials     1065     1064       -1     

see 16 files with indirect coverage changes

@arvindbr8 arvindbr8 merged commit 2a617ca into grpc:master Feb 28, 2024
14 checks passed
@arvindbr8 arvindbr8 deleted the fix_pb_import_experimental branch February 28, 2024 23:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants