Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

xds: add LRS named metrics support #7027

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

danielzhaotongliu
Copy link
Contributor

@danielzhaotongliu danielzhaotongliu commented Mar 7, 2024

Design:

  • go/grpc-xds-lrs-named-metrics
  • go/lrs-named-metrics-design-review-slides
  • Implements gRFC A64 https://github.com/grpc/proposal/blob/master/A64-lrs-custom-metrics.md
  • Only include named metrics from OrcaLoadReport and remove all previous fields (e.g. CPU utilization, memory utilization, etc.) as they are unused
  • Added xDS clusterImpl balancer tests to verify named metrics aggregation logic
  • Added completely missing tests for UpstreamLocalityStats to verify aggregation logic

Tested:

  • VET_SKIP_PROTO=1 ./vet.sh
  • go test -cpu 1,4 -timeout 7m ./...
  • go test -race -cpu 1,4 -timeout 7m ./...
  • Tested end-to-end by spinning up test client/server and verified named metrics from the OrcaLoadReport are aggregated and send in LRS load reports

RELEASE NOTES:

  • xds: implement LRS named metrics support (gRFC A64)

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #7027 (a71207c) into master (f7c5e6a) will decrease coverage by 0.05%.
Report is 5 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7027      +/-   ##
==========================================
- Coverage   82.48%   82.43%   -0.05%     
==========================================
  Files         296      296              
  Lines       31468    31463       -5     
==========================================
- Hits        25955    25937      -18     
- Misses       4457     4460       +3     
- Partials     1056     1066      +10     
Files Coverage Δ
xds/internal/balancer/clusterimpl/picker.go 96.73% <100.00%> (+8.07%) ⬆️

... and 22 files with indirect coverage changes

@dfawley dfawley self-assigned this Mar 13, 2024
@dfawley dfawley self-requested a review March 13, 2024 16:45
@dfawley dfawley added the Type: Feature New features or improvements in behavior label Mar 15, 2024
@dfawley dfawley added this to the 1.63 Release milestone Mar 15, 2024
@dfawley
Copy link
Member

dfawley commented Mar 15, 2024

Thanks for the PR!

@dfawley dfawley changed the title xds: LRS named metrics support xds: add LRS named metrics support Mar 15, 2024
@dfawley dfawley merged commit a1033b1 into grpc:master Mar 15, 2024
14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants