Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

channelz: re-add target and state #7042

Merged
merged 1 commit into from
Mar 18, 2024
Merged

channelz: re-add target and state #7042

merged 1 commit into from
Mar 18, 2024

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Mar 18, 2024

RELEASE NOTES: none

@dfawley dfawley added this to the 1.63 Release milestone Mar 18, 2024
@dfawley dfawley requested a review from arvindbr8 March 18, 2024 22:06
@dfawley dfawley self-assigned this Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Merging #7042 (b072c5f) into master (55cd7a6) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7042      +/-   ##
==========================================
- Coverage   82.39%   82.31%   -0.08%     
==========================================
  Files         299      299              
  Lines       31312    31314       +2     
==========================================
- Hits        25799    25777      -22     
- Misses       4453     4472      +19     
- Partials     1060     1065       +5     
Files Coverage Δ
clientconn.go 91.18% <100.00%> (+<0.01%) ⬆️
internal/channelz/funcs.go 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

@dfawley dfawley merged commit dadbbfa into grpc:master Mar 18, 2024
14 checks passed
@dfawley dfawley deleted the ff branch March 18, 2024 22:31
@sergiitk
Copy link
Member

For posterity: the regression introduced in #6969, internal ref b/330220025.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants