Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

channelz: re-add state for subchannels #7046

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Mar 19, 2024

RELEASE NOTES: none

@dfawley dfawley added this to the 1.63 Release milestone Mar 19, 2024
@dfawley dfawley requested a review from arvindbr8 March 19, 2024 15:38
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Merging #7046 (4366e7b) into master (dadbbfa) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7046      +/-   ##
==========================================
- Coverage   82.45%   82.29%   -0.16%     
==========================================
  Files         299      299              
  Lines       31314    31315       +1     
==========================================
- Hits        25819    25772      -47     
- Misses       4435     4475      +40     
- Partials     1060     1068       +8     
Files Coverage Δ
clientconn.go 91.19% <100.00%> (-1.57%) ⬇️

... and 12 files with indirect coverage changes

Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

clientconn.go Outdated Show resolved Hide resolved
@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 Mar 19, 2024
Co-authored-by: Arvind Bright <arvind.bright100@gmail.com>
@dfawley dfawley merged commit 800a8e0 into grpc:master Mar 19, 2024
14 checks passed
@dfawley dfawley deleted the fixsubchanstate branch March 19, 2024 17:53
@sergiitk
Copy link
Member

For posterity: the regression introduced in #6969, internal ref b/330220025.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants