Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

xds/internal/xdsclient/xdslbregistry: remove unused call to type url #7130

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

marcoferrer
Copy link
Contributor

@marcoferrer marcoferrer commented Apr 16, 2024

I was reading through the implementation for custom lb polices and noticed a call to the policy type URL wasn't being used

RELEASE NOTES: n/a

@aranjans aranjans added the Type: Internal Cleanup Refactors, etc label Apr 17, 2024
@aranjans aranjans requested a review from zasweq April 17, 2024 07:29
@aranjans aranjans added this to the 1.64 Release milestone Apr 17, 2024
@aranjans
Copy link
Contributor

aranjans commented Apr 17, 2024

@marcoferrer can you please add something like below as part of PR description?
"RELEASE NOTES: n/a"

@dfawley
Copy link
Member

dfawley commented Apr 17, 2024

can you please add something like below as part of PR description?

FYI for non-user-visible changes like this, we would use RELEASE NOTES: n/a (or none also works).

@zasweq zasweq changed the title remove unused call to type url xds/internal/xdsclient/xdslbregistry: remove unused call to type url Apr 18, 2024
@zasweq zasweq merged commit 81d3f06 into grpc:master Apr 18, 2024
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants