Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

cmd/protoc-gen-go-grpc: reuse route_guide_grpc.pb.go as golden file #7134

Merged
merged 5 commits into from
Apr 16, 2024
Merged

cmd/protoc-gen-go-grpc: reuse route_guide_grpc.pb.go as golden file #7134

merged 5 commits into from
Apr 16, 2024

Conversation

arvindbr8
Copy link
Member

@arvindbr8 arvindbr8 commented Apr 16, 2024 •
edited
Loading

Instead of using new proto files for golden files, let's reuse the ones we have under examples/route_guide. Lesser the better.

RELEASE NOTES: none

@arvindbr8 arvindbr8 added the Type: Internal Cleanup Refactors, etc label Apr 16, 2024
@arvindbr8 arvindbr8 added this to the 1.64 Release milestone Apr 16, 2024
@arvindbr8 arvindbr8 requested a review from dfawley April 16, 2024 23:26
@dfawley dfawley assigned arvindbr8 and unassigned dfawley Apr 16, 2024
@arvindbr8 arvindbr8 merged commit a2f8e61 into grpc:master Apr 16, 2024
12 checks passed
@arvindbr8 arvindbr8 deleted the fix_change_detector_test branch April 16, 2024 23:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@arvindbr8 arvindbr8

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.64 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@arvindbr8 @dfawley