advancedtls: Rename VType #7149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtcooke94
added
Type: Internal Cleanup
dfawley
reviewed
Apr 19, 2024
security/advancedtls/advancedtls.go
Outdated
Comment on lines
182
to
183
| // DEPRECATED: Renamed to `VerificationType` | ||
| // VType is the verification type on the client side. |
There was a problem hiding this comment.
The proper way to docstring this is:
// VType is blah blah
//
// Deprecated: use VerificationType instead.
VType VerificationType
security/advancedtls/advancedtls.go
Outdated
| // the `VerificationType` enum for the different options. | ||
| // Default: CertAndHostVerification | ||
| VerificationType VerificationType | ||
| // DEPRECATED: Renamed to `VerificationType` |
dfawley
approved these changes
Apr 19, 2024
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
VTypetoVerificationTypefor clarity.It marks
VTypeas deprecated. For now, ifVTypeis explicitly set (does not have the default value) then we setVerificationTypetoVTypeso that user behavior doesn't break.RELEASE NOTES: none