Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

peer: remove change detector test #7204

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

arvindbr8
Copy link
Member

This change detector test seems asserts for an exact match and relies on the go std library print statements which can be subjected to change.

RELEASE NOTES: none

@arvindbr8 arvindbr8 added this to the 1.64 Release milestone May 6, 2024
@arvindbr8 arvindbr8 requested a review from zasweq May 6, 2024 23:43
Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zasweq zasweq assigned arvindbr8 and unassigned zasweq May 6, 2024
@arvindbr8 arvindbr8 closed this May 6, 2024
@arvindbr8 arvindbr8 reopened this May 6, 2024
@dfawley dfawley closed this May 7, 2024
@dfawley dfawley reopened this May 7, 2024
@dfawley dfawley merged commit 9d9c1fb into grpc:master May 7, 2024
31 checks passed
@arvindbr8 arvindbr8 deleted the fix_one_pr branch May 30, 2024 00:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants