Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

github: update codecov with token and fail_ci_if_error #7348

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

arvindbr8
Copy link
Member

RELEASE NOTES: none

@arvindbr8 arvindbr8 added the Type: Meta Github repo, process, etc label Jun 24, 2024
@arvindbr8 arvindbr8 added this to the 1.66 Release milestone Jun 24, 2024
@arvindbr8
Copy link
Member Author

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.39%. Comparing base (4dd7f55) to head (609aa07).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7348      +/-   ##
==========================================
+ Coverage   80.58%   81.39%   +0.80%     
==========================================
  Files         349      348       -1     
  Lines       34056    26761    -7295     
==========================================
- Hits        27445    21781    -5664     
+ Misses       5431     3786    -1645     
- Partials     1180     1194      +14     

see 307 files with indirect coverage changes

@arvindbr8
Copy link
Member Author

That didnt work; I updated codecov to v4 and now it works: https://github.com/grpc/grpc-go/actions/runs/9652538323/job/26622886451?pr=7348

@dfawley dfawley assigned arvindbr8 and unassigned dfawley Jun 24, 2024
@arvindbr8 arvindbr8 merged commit 1811c6f into grpc:master Jun 24, 2024
13 checks passed
@arvindbr8 arvindbr8 linked an issue Jun 25, 2024 that may be closed by this pull request
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Type: Meta Github repo, process, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Action: Codecov action is broken and is failing silently
2 participants