-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
transport/grpchttp2: change types to include mem
package
#7477
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7477 +/- ##
==========================================
+ Coverage 81.40% 81.56% +0.16%
==========================================
Files 357 357
Lines 27243 27224 -19
==========================================
+ Hits 22176 22206 +30
+ Misses 3850 3811 -39
+ Partials 1217 1207 -10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work integrating the mem package. One more step closer to the finish line.
cc: @easwars - I'm okay to merge, unless you have any comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one minor comment left.
Since the
mem
package is now part of master, we can include the typings into the new framer interface.RELEASE NOTES: none