Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

transport/grpchttp2: change types to include mem package #7477

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

printchard
Copy link
Contributor

Since the mem package is now part of master, we can include the typings into the new framer interface.

RELEASE NOTES: none

@printchard printchard added the Type: Internal Cleanup Refactors, etc label Aug 2, 2024
@printchard printchard added this to the 1.66 Release milestone Aug 2, 2024
@printchard printchard requested a review from arvindbr8 August 2, 2024 18:02
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.56%. Comparing base (e524655) to head (32d6bfa).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7477      +/-   ##
==========================================
+ Coverage   81.40%   81.56%   +0.16%     
==========================================
  Files         357      357              
  Lines       27243    27224      -19     
==========================================
+ Hits        22176    22206      +30     
+ Misses       3850     3811      -39     
+ Partials     1217     1207      -10     
Files Coverage Δ
internal/transport/grpchttp2/framer.go 0.00% <ø> (ø)

... and 23 files with indirect coverage changes

Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work integrating the mem package. One more step closer to the finish line.

cc: @easwars - I'm okay to merge, unless you have any comments

@arvindbr8 arvindbr8 assigned easwars and unassigned arvindbr8 Aug 2, 2024
@easwars easwars assigned printchard and unassigned easwars Aug 2, 2024
@printchard printchard requested a review from easwars August 3, 2024 01:23
@printchard printchard assigned easwars and unassigned printchard Aug 3, 2024
Copy link
Contributor

@easwars easwars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one minor comment left.

@easwars easwars assigned printchard and unassigned easwars Aug 6, 2024
@easwars easwars merged commit e6b6318 into grpc:master Aug 6, 2024
13 checks passed
printchard added a commit to printchard/grpc-go that referenced this pull request Aug 6, 2024
infovivek2020 pushed a commit to infovivek2020/grpc-go that referenced this pull request Aug 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants