Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

github/workflows: Fix the tag used to enable buffer leak checks #7670

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Sep 24, 2024

The build tag used to enable buffer leaks is defined here:

//go:build checkbuffers

The Github workflow seems to be using the wrong tag name.

RELEASE NOTES: N/A

@arjan-bal arjan-bal added Type: Testing Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. labels Sep 24, 2024
@arjan-bal arjan-bal added this to the 1.68 Release milestone Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.94%. Comparing base (e7a8097) to head (ba4720f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7670      +/-   ##
==========================================
+ Coverage   81.80%   81.94%   +0.14%     
==========================================
  Files         361      361              
  Lines       27821    27821              
==========================================
+ Hits        22758    22799      +41     
+ Misses       3862     3834      -28     
+ Partials     1201     1188      -13     

see 20 files with indirect coverage changes

@arjan-bal arjan-bal changed the title github/workflows: Fix the tag used to enable buffer leaks github/workflows: Fix the tag used to enable buffer leak checks Sep 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. Type: Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant