Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cherry-pick #7724 to 1.68.x #7793

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

purnesh42H
Copy link
Contributor

@purnesh42H purnesh42H commented Oct 29, 2024

Original PR (#7724)

RELEASE NOTES:

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 32.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 81.77%. Comparing base (b79fb61) to head (a79ba96).
Report is 1 commits behind head on v1.68.x.

Files with missing lines Patch % Lines
.../grpc_testing_not_regenerated/simple_message_v1.go 29.16% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           v1.68.x    #7793      +/-   ##
===========================================
+ Coverage    81.31%   81.77%   +0.45%     
===========================================
  Files          362      364       +2     
  Lines        35671    35899     +228     
===========================================
+ Hits         29006    29356     +350     
+ Misses        5475     5354     -121     
+ Partials      1190     1189       -1     
Files with missing lines Coverage Δ
internal/status/status.go 90.52% <100.00%> (ø)
testdata/grpc_testing_not_regenerated/testv3.go 6.86% <ø> (ø)
.../grpc_testing_not_regenerated/simple_message_v1.go 29.16% <29.16%> (ø)

... and 21 files with indirect coverage changes

Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vet is failing because - staticcheck @ v1.68.0 runs with --go 1.21 flag

This is non blocking

@arvindbr8 arvindbr8 assigned purnesh42H and unassigned arvindbr8 and dfawley Oct 29, 2024
@purnesh42H purnesh42H merged commit 056dc64 into grpc:v1.68.x Oct 30, 2024
14 of 15 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants