xds: add xdsTransportFactory interface #10827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YifeiZhuang
force-pushed
the
xds-transport-factory
branch
from
ccd4beb to
6144f1a
Compare
|
We don't currently have an XdsChannelTransport, so the description is a little confusing to me. I'm sure that there will need to be discussions about the class name. |
larry-safran
requested changes
Jan 16, 2024
larry-safran
approved these changes
Jan 16, 2024
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirror C++ implementation.
https://source.corp.google.com/piper///depot/google3/third_party/grpc/src/core/ext/xds/xds_transport.h
This interface will be used to replace
XdsChannelTransport.Next step: ControlPlaneClient and LrsClient will implement the XdsTransport defined here.