Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

opentelemetry: Add explicit histogram buckets for per-call metrics #11281

Merged
merged 4 commits into from
Jun 12, 2024
Merged

opentelemetry: Add explicit histogram buckets for per-call metrics #11281

merged 4 commits into from
Jun 12, 2024

Conversation

DNVindhya
Copy link
Contributor

As part of gRFC A66:

Buckets for histograms in default views should be as follows -
Latency : 0, 0.00001, 0.00005, 0.0001, 0.0003, 0.0006, 0.0008, 0.001, 0.002, 0.003, 0.004, 0.005, 0.006, 0.008, 0.01, 0.013, 0.016, 0.02, 0.025, 0.03, 0.04, 0.05, 0.065, 0.08, 0.1, 0.13, 0.16, 0.2, 0.25, 0.3, 0.4, 0.5, 0.65, 0.8, 1, 2, 5, 10, 20, 50, 100
Size : 0, 1024, 2048, 4096, 16384, 65536, 262144, 1048576, 4194304, 16777216, 67108864, 268435456, 1073741824, 4294967296

This PR adds histogram bucket boundaries for per-call metrics.

CC @yashykt

@DNVindhya DNVindhya requested a review from ejona86 June 12, 2024 06:08
ejona86
ejona86 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably will want to only test hasBucketCounts() once for each metric, but this is fine for now.

@DNVindhya DNVindhya added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Jun 12, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Jun 12, 2024
ejona86 added a commit to ejona86/grpc-java that referenced this pull request Jun 12, 2024
@ejona86
Disable ErrorProne's MutableConstantField check
d6b4c14 
It is simultaneously overly zealous and doesn't notice basic cases. As
noticed in grpc#11281.
ejona86 added a commit to ejona86/grpc-java that referenced this pull request Jun 12, 2024
@ejona86
Disable ErrorProne's MutableConstantField check
644879e 
It is simultaneously overly zealous and doesn't notice basic cases. As
noticed in grpc#11281.
@ejona86 ejona86 mentioned this pull request Jun 12, 2024
Merged
@ejona86 ejona86 added the TODO:backport PR needs to be backported. Removed after backport complete label Jun 12, 2024
ejona86 added a commit that referenced this pull request Jun 12, 2024
@ejona86
Disable ErrorProne's MutableConstantField check (#11283)
a4ef771 
It is simultaneously overly zealous and doesn't notice basic cases. As
noticed in #11281.
@DNVindhya DNVindhya merged commit b43d283 into grpc:master Jun 12, 2024
13 checks passed
@DNVindhya DNVindhya deleted the opentelemetry-explicit-bucket-boundary branch June 12, 2024 23:57
DNVindhya added a commit to DNVindhya/grpc-java that referenced this pull request Jun 13, 2024
@DNVindhya
opentelemetry: Add explicit histogram buckets for per-call metrics (g…
5161e15 
…rpc#11281)

Add explicit histogram buckets for per-call metrics as specified in gRFC A66 https://github.com/grpc/proposal/blob/master/A66-otel-stats.md#units.
@DNVindhya DNVindhya mentioned this pull request Jun 13, 2024
Merged
DNVindhya pushed a commit to DNVindhya/grpc-java that referenced this pull request Jun 13, 2024
@ejona86 @DNVindhya
Disable ErrorProne's MutableConstantField check (grpc#11283)
577ce8d 
It is simultaneously overly zealous and doesn't notice basic cases. As
noticed in grpc#11281.
@DNVindhya DNVindhya mentioned this pull request Jun 13, 2024
Merged
DNVindhya added a commit that referenced this pull request Jun 13, 2024
@DNVindhya
Disable ErrorProne's MutableConstantField check (#11283) (#11288)
513c047 
It is simultaneously overly zealous and doesn't notice basic cases. As
noticed in #11281.
DNVindhya added a commit to DNVindhya/grpc-java that referenced this pull request Jun 14, 2024
@DNVindhya
opentelemetry: Add explicit histogram buckets for per-call metrics (g…
61464f2 
…rpc#11281)

Add explicit histogram buckets for per-call metrics as specified in gRFC A66 https://github.com/grpc/proposal/blob/master/A66-otel-stats.md#units.
DNVindhya added a commit that referenced this pull request Jun 14, 2024
@DNVindhya
opentelemetry: Add explicit histogram buckets for per-call metrics (#…
71eca4e 
…11281) (#11287)

Add explicit histogram buckets for per-call metrics as specified in gRFC A66 https://github.com/grpc/proposal/blob/master/A66-otel-stats.md#units.
@DNVindhya DNVindhya removed the TODO:backport PR needs to be backported. Removed after backport complete label Jun 14, 2024
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Aug 13, 2024
@ejona86 @larry-safran
Disable ErrorProne's MutableConstantField check (grpc#11283)
5379d75 
It is simultaneously overly zealous and doesn't notice basic cases. As
noticed in grpc#11281.
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Aug 13, 2024
@DNVindhya @larry-safran
opentelemetry: Add explicit histogram buckets for per-call metrics (g…
b029a7d 
…rpc#11281)

Add explicit histogram buckets for per-call metrics as specified in gRFC A66 https://github.com/grpc/proposal/blob/master/A66-otel-stats.md#units.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DNVindhya @ejona86 @grpc-kokoro