-
Notifications
You must be signed in to change notification settings - Fork 3.9k
xds: Envoy proto sync to 2024-11-11 #11816
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
The failure is due to the deprecation of setMetadata() in Builder. See rbac.proto I tried to replace it with
METADATA .
For now I can add a suppress warning for deprecation to the test method and create a tracking issue to this. |
We need to still support the old field, so |
(And implementing sourced_metadata would be cross-language, so would have a gRFC. The issue can mention that.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to delete the tar.gz; that should not be checked into the repository.
envoyproxy/envoy: Sync protos to the latest imported version envoyproxy/envoy@0b90f64 (commit 2024-11-11).
Should be a noop, just a routine xDS proto update to make upcoming xDS-HTTP CONNECT related imports simpler.