-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[xDS] A97 - JWT token file call creds #12242
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Open
Zgoda91
wants to merge
5
commits into
grpc:master
Choose a base branch
from
Zgoda91:A97_jwt_token_call_creds
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8f76b0
to
c781460
Compare
@ejona86 Could you please review this PR when you get a chance? Thanks! |
ejona86
reviewed
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shape of what I saw looked good. I didn't pay attention to any of the tests yet. I need to look through the provider plumbing more. But wanted to send the comments I have.
alts/src/main/java/io/grpc/alts/JwtTokenFileCallCredentials.java
Outdated
Show resolved
Hide resolved
alts/src/testFixtures/java/io/grpc/alts/JwtTokenFileTestUtils.java
Outdated
Show resolved
Hide resolved
alts/src/testFixtures/java/io/grpc/alts/JwtTokenFileTestUtils.java
Outdated
Show resolved
Hide resolved
xds/src/main/java/io/grpc/xds/internal/JwtTokenFileXdsCredentialsProvider.java
Outdated
Show resolved
Hide resolved
alts/src/main/java/io/grpc/alts/JwtTokenFileCallCredentials.java
Outdated
Show resolved
Hide resolved
alts/src/main/java/io/grpc/alts/JwtTokenFileCallCredentials.java
Outdated
Show resolved
Hide resolved
alts/src/main/java/io/grpc/alts/JwtTokenFileCallCredentials.java
Outdated
Show resolved
Hide resolved
c781460
to
85495b0
Compare
85495b0
to
9f97bb5
Compare
@ejona86 PR ready for second round |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementing gRFC A97 grpc/proposal#492