core: Avoid wrapping Errors in RuntimeException #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,7 +58,8 @@ public void run() { | |||
| task.run(); | |||
| } catch (Throwable t) { | |||
| log.log(Level.SEVERE, "Exception while executing runnable " + task, t); | |||
| throw t instanceof RuntimeException ? (RuntimeException) t : new RuntimeException(t); | |||
| Throwables.propagateIfPossible(t); | |||
| throw new AssertionError(t); | |||
There was a problem hiding this comment.
This will either be an Exception or a raw Throwable (or a subclass of Throwable that isn't RE or E).
Is wrapping in an AE appropriate?
There was a problem hiding this comment.
The only classes that are unchecked is RuntimeException and Error (and children). So getting to this line should not be possible (without hacks). So AssertionError seems fitting.
There was a problem hiding this comment.
This may be dumb, but won't all checked exceptions reach that point?
There was a problem hiding this comment.
Happened to discuss offline. run() declares no checked exceptions.
|
LGTM |
ejona86
added
the
TODO:backport
zhangkun83
removed
the
TODO:backport
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.