Skip to content

all: introduce gradle util functions to manage guava dependency #7000

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 2, 2020

Conversation

dapengzhang0
Copy link
Member

@dapengzhang0 dapengzhang0 commented May 1, 2020

Define util function to exclude guava's transitive dependencies jsr305 and animal-sniffer-annotations, and always manually add them as runtimeOnly dependency. error_prone_annotations is an exception: It is also excluded but manually added not as runtimeOnly. It must always compile with guava, otherwise users will see warning spams if guava is in the compile classpath but error_prone_annotations is not.

@dapengzhang0 dapengzhang0 requested review from voidzcy and ejona86 May 1, 2020 23:40
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit concerned that the explicit dependencies on the libraries were not cleaned up, but I understand that will be a follow-up PR. I'll just re-iterate that this change was fine in the earlier PR.

voidzcy
voidzcy approved these changes May 2, 2020
@dapengzhang0 dapengzhang0 merged commit ce9d217 into grpc:master May 2, 2020
@dapengzhang0 dapengzhang0 deleted the guava branch May 2, 2020 05:59
@dapengzhang0
Copy link
Member Author

I'm a bit concerned that the explicit dependencies on the libraries were not cleaned up, but I understand that will be a follow-up PR. I'll just re-iterate that this change was fine in the earlier PR.

erroprone dep in grpc-api is cleaned up in the followup PR #7001. errorpone in grpc-core is kept there because it is still an implementation dependency for grpc-core although without it the build can still pass. Were there anything else need be cleaned up?

@ejona86
Copy link
Member

ejona86 commented May 4, 2020

I think with those, the only one left would be animalsniffer_annotations in grpc-api looks unused.

@dapengzhang0
Copy link
Member Author

Yes, animalsniffer_annotations in grpc-api is also cleaned up in the followup PR.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants