Skip to content

grpc-js: fix target in tracing logs #1387

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

badsyntax
Copy link
Contributor

@badsyntax badsyntax commented Apr 23, 2020

I'm attempting to debug a random "failed to parse server response" error and this is what i'm seeing in my logs (note the [object Object]):

2020-04-23T06:13:06.747Z | dns_resolver | Resolved addresses for target [object Object]: [::1:57426,127.0.0.1:57426]
2020-04-23T06:13:06.747Z | pick_first | IDLE -> IDLE
2020-04-23T06:13:06.748Z | resolving_load_balancer | [object Object] CONNECTING -> IDLE
2020-04-23T06:13:06.748Z | connectivity_state | [object Object] CONNECTING -> IDLE
2020-04-23T06:13:06.748Z | dns_resolver | Resolution update requested for target [object Object]
2020-04-23T06:13:06.748Z | resolving_load_balancer | [object Object] IDLE -> CONNECTING
2020-04-23T06:13:06.748Z | connectivity_state | [object Object] IDLE -> CONNECTING
2020-04-23T06:13:06.748Z | resolving_load_balancer | [object Object] CONNECTING -> CONNECTING

I guess this is related to #1364

Copy link
Member

@murgatroid99 murgatroid99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some of this yesterday, but I didn't get around to dealing with it. Thank you for fixing it.

@murgatroid99 murgatroid99 merged commit 5d54686 into grpc:master Apr 23, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants