Skip to content

grpc-js: Add support for grpc.enable_http_proxy channel option #1454

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2020
Merged

grpc-js: Add support for grpc.enable_http_proxy channel option #1454

merged 1 commit into from
Jun 1, 2020

Conversation

badsyntax
Copy link
Contributor

@badsyntax badsyntax commented Jun 1, 2020 •
edited
Loading

Fixes #1453

This change adds support for the grpc.enable_http_proxy channel option.

@badsyntax badsyntax mentioned this pull request Jun 1, 2020
Closed
@badsyntax badsyntax mentioned this pull request Jun 1, 2020
Closed
@badsyntax
Copy link
Contributor Author

@murgatroid99 Just wondering, if you're happy with this change, it can be released with 1.0.5?

murgatroid99
murgatroid99 approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@murgatroid99 murgatroid99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this. This will go out in 1.0.5.

@murgatroid99 murgatroid99 merged commit 136626a into grpc:master Jun 1, 2020
@badsyntax badsyntax deleted the enable_http_proxy branch June 4, 2020 08:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@murgatroid99 murgatroid99 murgatroid99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grpc-js: disable http proxy with client options
3 participants
@badsyntax @murgatroid99 @kokoro-team