Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix handling of undefined values for optional call arguments #179

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Fix handling of undefined values for optional call arguments #179

merged 1 commit into from
Feb 13, 2018

Conversation

murgatroid99
Copy link
Member

This fixes #178.

@murgatroid99 murgatroid99 mentioned this pull request Feb 13, 2018
Merged
kjin
kjin approved these changes Feb 13, 2018
View reviewed changes
Copy link
Contributor

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems like it would be nice to have a helper function (in the same fashion as the arg parser library that was being used before) but it's not necessary.

@murgatroid99 murgatroid99 merged commit b5facc9 into grpc:v1.9.x Feb 13, 2018
@XadillaX XadillaX mentioned this pull request Apr 26, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@kjin kjin kjin approved these changes

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murgatroid99 @kjin