Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve performance of batch operation serializer #215

Merged

Conversation

drobertduke
Copy link
Contributor

This is a follow-up to #59, addressing the performance penalties of the code I wrote to enforce a certain order in batch operations, as discussed here: #59 (comment)

This replaces the worst-performing lodash and standard library calls. In micro-benchmarks, _startBatchIfReady runs in about half the time after these changes are applied.

@murgatroid99
Copy link
Member

Can you rebase this change against the v1.10.x branch and either update this PR or send a new one?

@drobertduke
Copy link
Contributor Author

@murgatroid99 The code this is based on is not in v1.10.x, #59 was merged to master after 1.10.x was cut.

@murgatroid99
Copy link
Member

You're right. Never mind.

@murgatroid99 murgatroid99 merged commit 399ae5e into grpc:master Mar 13, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants