Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(grpc-js): client crash on custom error code #2801

Merged
merged 2 commits into from
Jul 26, 2024
Merged

fix(grpc-js): client crash on custom error code #2801

merged 2 commits into from
Jul 26, 2024

Conversation

hastom
Copy link
Contributor

@hastom hastom commented Jul 18, 2024

In version 1.11.1, grpc client crashes if receives custom error code with error cannot read properties of undefined reading .toLowerCase()

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jul 18, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@murgatroid99 murgatroid99 changed the base branch from master to @grpc/grpc-js@1.11.x July 19, 2024 17:52
@murgatroid99 murgatroid99 merged commit f5ea6ce into grpc:@grpc/grpc-js@1.11.x Jul 26, 2024
4 of 5 checks passed
@murgatroid99 murgatroid99 mentioned this pull request Jul 26, 2024
Merged
@murgatroid99
Copy link
Member

This is out in version 1.11.2

@j-mendez j-mendez mentioned this pull request Nov 1, 2024
Open
@MrRaja23 MrRaja23 mentioned this pull request Nov 2, 2024
Open
@thiswayman thiswayman mentioned this pull request Nov 5, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@murgatroid99 murgatroid99 murgatroid99 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hastom @murgatroid99 @kokoro-team