-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adding fix to ignore self-signed certificates verification #2812
Adding fix to ignore self-signed certificates verification #2812
Conversation
c44f165
to
ca9f8c7
Compare
In the referenced issue, you mention that the Go implementation accomplishes this with a TLS credentials option. I think we should take the same approach in Node, rather than introducing a new channel option. Both |
I tried with verifyOptions checkServerIdentity: () => null, but with this, I was able to disable only the hostname/CN name verification. I'm still getting error for self signed certificate. I see only rejectUnauthorized: false to bypass the verification of self-signed certificates and allows the client to make SSL requests without validating the server’s SSL certificate @murgatroid99 |
I am suggesting that instead of adding a channel option, we add a field to |
@murgatroid99 - Yes, made changes. could you please now check ? |
Adding fix to ignore self-signed certificates verification