grpc-js: Improve event sequencing when handling connection drops #2862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes a few things to try to report connection drops with the UNAVAILABLE status more consistently:
setImmediate
, to ensure that the call sees the event as quickly as possible.setImmediate
to mimic the old sequencing in most cases, but first flags that a connection drop event was seen. User reports indicate that Node (or nghttp2) probably synthesizes a RST_STREAM with the code CANCEL when a connection drops, so if the connection drop flag is set we treat that code as UNAVAILABLE instead of CANCELLED.