Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: xds-client LrsCallState statsTimer memory leak #2891

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix: xds-client LrsCallState statsTimer memory leak #2891

merged 2 commits into from
Feb 4, 2025

Conversation

gfrancz
Copy link
Contributor

@gfrancz gfrancz commented Jan 28, 2025

No description provided.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 28, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@gfrancz gfrancz mentioned this pull request Jan 28, 2025
Closed
@murgatroid99
Copy link
Member

Build error:

src/xds-client.ts:693:7 - error TS2322: Type 'void' is not assignable to type 'Timeout | null'.

693       this.statsTimer = clearInterval(this.statsTimer);
          ~~~~~~~~~~~~~~~

Please fix, and ensure that the code compiles before pushing, and please sign the CLA.

@gfrancz @ws-gregm
Fix type issue by setting the attribute separately
6dc3abe 
Co-authored-by: ws-gregm <55088361+ws-gregm@users.noreply.github.com>
@gfrancz
Copy link
Contributor Author

gfrancz commented Feb 4, 2025

Ok sorry about that -- CLA is signed, I've confirmed it builds.

@ws-gregm
Copy link
Contributor

ws-gregm commented Feb 4, 2025

@murgatroid99 It appears that this PR and this one are blocked on Windows Tests which is failing because of timeout with test. I'm looking into it but I suspect it's a false fail.

@murgatroid99
Copy link
Member

Ignore the Windows tests. The test results are fine

murgatroid99
murgatroid99 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@murgatroid99 murgatroid99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix.

@murgatroid99 murgatroid99 merged commit d2a6dda into grpc:master Feb 4, 2025
4 of 5 checks passed
@murgatroid99 murgatroid99 mentioned this pull request Feb 4, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ws-gregm ws-gregm

@murgatroid99 murgatroid99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gfrancz @murgatroid99 @ws-gregm @kokoro-team