Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

grpc-js-xds: fix LrsCallState statsTimer memory leak #2898

Merged
merged 3 commits into from
Feb 4, 2025
Merged

grpc-js-xds: fix LrsCallState statsTimer memory leak #2898

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
621f401
fix: xds-client LrsCallState statsTimer memory leak
gfrancz Jan 28, 2025
588b69c
Fix type issue by setting the attribute separately
gfrancz Feb 4, 2025
f1f2b2d
grpc-js-xds: Bump to version 1.12.2
murgatroid99 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/grpc-js-xds/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@grpc/grpc-js-xds",
"version": "1.12.1",
"version": "1.12.2",
"description": "Plugin for @grpc/grpc-js. Adds the xds:// URL scheme and associated features.",
"main": "build/src/index.js",
"scripts": {
10 changes: 9 additions & 1 deletion packages/grpc-js-xds/src/xds-client.ts
View file
Original file line number Diff line number Diff line change
@@ -682,6 +682,14 @@ class LrsCallState {
this.sendStats();
}

destroy() {
if (this.statsTimer) {
clearInterval(this.statsTimer);
this.statsTimer = null;
}
return null;
}

private handleStreamStatus(status: StatusObject) {
this.client.trace(
'LRS stream ended. code=' + status.code + ' details= ' + status.details
@@ -932,7 +940,7 @@ class XdsSingleServerClient {
}

handleLrsStreamEnd() {
this.lrsCallState = null;
this.lrsCallState = this.lrsCallState ? this.lrsCallState.destroy() : null;
/* The backoff timer would start the stream when it finishes. If it is not
* running, restart the stream immediately. */
if (!this.lrsBackoff.isRunning()) {