Skip to content
This repository has been archived by the owner on Apr 9, 2021. It is now read-only.

Use defined variable in C++ auth example #394

Merged
merged 1 commit into from
Mar 21, 2017
Merged

Conversation

codegoalie
Copy link

The comment does say "using the credentials created in the previous step," but I think it's still better using the same variable name.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@codegoalie
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Member

@vjpai vjpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vjpai vjpai merged commit 9d3ffe6 into grpc:master Mar 21, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants