This repository has been archived by the owner on Apr 9, 2021. It is now read-only.
Add link to "latest_release" perf dashboard #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
friendly ping. since this is a trivial change, adding @matt-kwong as alternative reviewer |
matt-kwong
reviewed
Mar 7, 2017
docs/guides/benchmarking.md
Outdated
| * [Multi-language performance dashboard @v1.0.0](https://performance-dot-grpc-testing.appspot.com/explore?dashboard=5712453606309888) | ||
| * [Multi-language performance dashboard @master](https://performance-dot-grpc-testing.appspot.com/explore?dashboard=5652536396611584) | ||
| * [C++ detailed performance dashboard @master](https://performance-dot-grpc-testing.appspot.com/explore?dashboard=5632763172487168) | ||
| * [Multi-language performance dashboard @latest_release (=lastest available stable release)](http://performance-dot-grpc-testing.appspot.com/explore?dashboard=5636470266134528) |
There was a problem hiding this comment.
nit: change this to https to be consistent with the other links
docs/guides/benchmarking.md
Outdated
| * [Multi-language performance dashboard @v1.0.0](https://performance-dot-grpc-testing.appspot.com/explore?dashboard=5712453606309888) | ||
| * [Multi-language performance dashboard @master](https://performance-dot-grpc-testing.appspot.com/explore?dashboard=5652536396611584) | ||
| * [C++ detailed performance dashboard @master](https://performance-dot-grpc-testing.appspot.com/explore?dashboard=5632763172487168) | ||
| * [Multi-language performance dashboard @latest_release (=lastest available stable release)](http://performance-dot-grpc-testing.appspot.com/explore?dashboard=5636470266134528) |
There was a problem hiding this comment.
I'm not the biggest fan of adding the parenthesis, but if we do go with them, I think it would look better without the = signs
|
Comments addressed. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @adelez, @matt-kwong, @apolcyn,