Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

A47 update: EDS resource name field is required for new-style CDS resources #377

Merged
merged 1 commit into from
Jun 13, 2023
Merged

A47 update: EDS resource name field is required for new-style CDS resources #377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions A47-xds-federation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,22 @@ resource is not already present in the cache, it will send a message
subscribing to the resource, using the appropriate xDS server from the
authority.

##### CDS Resource Validation

For an EDS cluster, the CDS resource currently specifies the name of the
EDS resource in its `eds_cluster_config.service_name` field. Currently,
the expected behavior is that if that field is unset, the EDS resource
name will be the same as the CDS resource name. However, with
new-style resource names, the resource type is part of the resource
name, which means that this default will no longer work, because it
would result in an EDS resource name that specifies the CDS resource
type in its name.

To address this, when the `XdsClient` validates a CDS resource, if the CDS
resource's name starts with `xdstp:`, then the CDS resource for an EDS
cluster will be considered invalid if the `eds_cluster_config.service_name`
field is unset.

#### LRS Server Representation

We currently represent the LRS server name in several places:
Expand Down