Coverity fixes #61
Merged
Coverity fixes #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cast to int to pass in the correct value (important on big endian machines). Signed-off-by: Simo Sorce <simo@redhat.com>
We never call this function in a way that the null dereference would happen. However there is no point in riskying it should the code change inf future. Rework the code to bail out early and avoid the issue. Signed-off-by: Simo Sorce <simo@redhat.com>
Additional type fixes where a long was passed in. Signed-off-by: Simo Sorce <simo@redhat.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.