Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

Re-export cairo-sys as ffi. #343

Closed
wants to merge 1 commit into from

Conversation

richard-uk1
Copy link
Contributor

Closes #342

2 questions:

  • Do you prefer with doc(inline) or without? Run cargo doc with and without to see the difference.
  • What other crates should I do this for?

@sdroege
Copy link
Member

sdroege commented Oct 23, 2020

Do you prefer with doc(inline) or without? Run cargo doc with and without to see the difference.

@GuillaumeGomez ?

What other crates should I do this for?

I guess this should be done for glib, gio, pango, pangocairo, atk, gdk-pixbuf, gdk, gtk, graphene, gsk4, gdk4, gtk4. If you don't want to do it for all of them that's ok, we can do the others.

@sdroege
Copy link
Member

sdroege commented Oct 23, 2020

I guess this should be done for glib, gio, pango, pangocairo, atk, gdk-pixbuf, gdk, gtk, graphene, gsk4, gdk4, gtk4. If you don't want to do it for all of them that's ok, we can do the others.

In case of glib there's glib_sys and gobject_sys. Which should probably become glib::ffi and glib::gobject_ffi I guess?

@GuillaumeGomez
Copy link
Member

Without doc(inline) preferably.

Amend: remove doc(inline)
@richard-uk1
Copy link
Contributor Author

I've removed doc(inline). As a bonus, it makes the diff very small :D.

As for the other crates, I would maybe prefer if you made the changes, because you will be more aware of things like the gobject_ffi naming issue. But if you want you can ask me to change some or all of them and I will do the corresponding PRs. Let me know on this issue which ones you would like me to change, if any.

@GuillaumeGomez
Copy link
Member

Hey @derekdreery ! We migrated the cairo crate into the gtk-rs/gtk-rs repository. Could you please reopen your PR there? :)

@richard-uk1 richard-uk1 deleted the reexport_sys branch November 2, 2020 10:36
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider re-exporting cairo-sys-rs under ffi.
3 participants