Skip to content
This repository was archived by the owner on Jun 8, 2021. It is now read-only.

Remove missed callback_guard #66

Merged
merged 1 commit into from
Feb 17, 2018

Conversation

EPashkin
Copy link
Member

Part of gtk-rs/glib#250

Forgot some manual calls

@GuillaumeGomez

@EPashkin
Copy link
Member Author

Hm, seems all rt.rs need removing

@EPashkin
Copy link
Member Author

Or better leave with assert_initialized_main_thread with #[allow(unused_macros)]?
Currently it sole macro in rt.rs and unused in generated code.

@GuillaumeGomez
Copy link
Member

We should really move all the macros inside a common crate. It'd make such things simpler. Anyway, if they're not used, just remove them.

@EPashkin EPashkin force-pushed the remove_callback_guard branch from 1462bd8 to 2879974 Compare February 17, 2018 20:38
@EPashkin
Copy link
Member Author

Updated.

Moving to common crates IMHO impossible as these macros has different meaning in all your crates.

@EPashkin
Copy link
Member Author

Single travis failure again.
@GuillaumeGomez Maybe some timeouts need increase?

@EPashkin
Copy link
Member Author

But no printing for 10min still strange, maybe it some infrastructure problem.

@GuillaumeGomez
Copy link
Member

I think so. Let's merge. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 2aba23c into gtk-rs:master Feb 17, 2018
@EPashkin EPashkin deleted the remove_callback_guard branch February 18, 2018 06:34
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants