This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Make Value APIs safer and remove redundancies
#238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `set_value` check that the column number is valid and the value type is appropriate. Remove `set_column_types` -- it only works in very limited circumstances. Remove `set_string` -- `set_value` supports setting string values ergonomically. [breaking change]
gkoz
changed the title
Value breakageValue APIs safer and remove redundancies
|
While meddling with |
|
I agree. Since similar changes like this have been made all around, why not here as well? |
GuillaumeGomez
added a commit
that referenced
this pull request
Jan 23, 2016
Make `Value` APIs safer and remove redundancies
EPashkin
pushed a commit
to EPashkin/gtk
that referenced
this pull request
Apr 18, 2016
Replace match...Err block with equivalent unwrap()
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.