Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

add manual doc aliases #227

Merged
merged 9 commits into from
Jan 12, 2021
Merged

add manual doc aliases #227

merged 9 commits into from
Jan 12, 2021

Conversation

bilelmoussaoui
Copy link
Member

No description provided.

Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like my script missed quite a lot... Thanks!

@bilelmoussaoui
Copy link
Member Author

More are coming!

@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/doc-alias branch 2 times, most recently from 41cc19d to 2405bdf Compare December 20, 2020 18:57
@bilelmoussaoui bilelmoussaoui changed the title WIP: add manual doc aliases add manual doc aliases Dec 20, 2020
@bilelmoussaoui
Copy link
Member Author

Ok I think have done enough for now

@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/doc-alias branch from 2405bdf to 4b41caa Compare December 20, 2020 19:12
@@ -19,6 +19,7 @@ pub struct InitializingType<T>(pub(crate) Type, pub(crate) marker::PhantomData<*

impl<T: ObjectSubclass> InitializingType<T> {
/// Adds an interface implementation for `I` to the type.
#[doc(alias = "g_type_add_interface_static")]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdroege regarding this one, does it make sense to have doc aliases for subclassing support as well? :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure why not

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do another round in a separate MR later then :)

@GuillaumeGomez
Copy link
Member

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 4e8911b into master Jan 12, 2021
@GuillaumeGomez GuillaumeGomez deleted the bilelmoussaoui/doc-alias branch January 12, 2021 10:26
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants