This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Consistently re-export subclassing preludes of dependency crates #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
force-pushed
the
subclass-preludes
branch
from
6e5d844 to
aaced39
Compare
| #[doc(hidden)] | ||
| pub use gio::subclass::prelude::*; | ||
| #[doc(hidden)] | ||
| pub use glib::subclass::prelude::*; |
There was a problem hiding this comment.
What does it allow to do btw?
There was a problem hiding this comment.
Not having to import all the subclass preludes every time. Same as what was done for the normal preludes.
There was a problem hiding this comment.
I never used subclass so I really can't judge here. I'll trust you here. :)
bilelmoussaoui
approved these changes
Dec 20, 2020
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bilelmoussaoui Same change is also needed for gtk4 I guess