Various minor cleanups #23
Conversation
|
This appears to revert the |
Yes, I hate git submodules :) Thanks for noticing! |
|
Once gtk-rs/gir#985 is in and we regenerate with that, we won't have any compiler warnings left with latest stable and nightly. How it should've always been. Can we have a github action that complains about warnings (makes them errors) and annotates PRs with them somehow? @bilelmoussaoui ? |
|
Definitely, I will handle that once my other CI additions are in |
| @@ -32,6 +32,7 @@ mod rt; | |||
| #[cfg_attr(feature = "cargo-clippy", allow(let_and_return))] | |||
| #[cfg_attr(feature = "cargo-clippy", allow(many_single_char_names))] | |||
| #[cfg_attr(feature = "cargo-clippy", allow(wrong_self_convention))] | |||
| #[allow(unused_imports)] | |||
There was a problem hiding this comment.
At some point it'd be nice if gir imports were fixed. :)
There was a problem hiding this comment.
Indeed, but that's quite non-trivial to get right :)
|
Thanks! |
No description provided.