This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Sync glib/cairo #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix https://github.com/gtk-rs/glib/pull/713/files#r511494658 By implementing it to invoke the traits on the wrapped `ObjectRef` the implementation shorter and clearer than before.
Not providing them is deprecated.
…ng object The object might just be finalized, and in that case it's unsafe to access it and use any API on it. This can only happen from inside the Drop impl of Self.
… finalizing or finalized objects This would be unsafe and hints at a bug somewhere else.
There are 4 left that are wrong upstream and have an MR submitted, all others are correct and this gets rid of some functions wrongly marked as possibly returning NULL.
GuillaumeGomez
approved these changes
Oct 29, 2020
|
Thanks! |
elmarco
pushed a commit
to elmarco/gtk-rs
that referenced
this pull request
Feb 10, 2021
Don't reexport prelude content
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.