This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @sdroege |
0d55084
to
c747353
Compare
(The header at the top of this file says it is auto-generated, but I didn't actually see where else the logic I'm patching would be coming from) |
There's a You'll have to edit the |
sdroege
reviewed
Oct 29, 2020
@sdroege thanks for the pointers, I'll massage the PR in that direction. |
c747353
to
cda1c2d
Compare
Amended, it should be slightly less nasty now (and I've checked that |
sdroege
reviewed
Oct 29, 2020
This tweaks `get_charset()` signature and logic to properly return both the charset label and the UTF-8 boolean.
cda1c2d
to
3c5be51
Compare
Amended to reshuffle the |
Thanks for fixing this, looks good to me now :) |
elmarco
pushed a commit
to elmarco/gtk-rs
that referenced
this pull request
Feb 10, 2021
elmarco
pushed a commit
to elmarco/gtk-rs
that referenced
this pull request
Feb 10, 2021
elmarco
pushed a commit
to elmarco/gtk-rs
that referenced
this pull request
Feb 10, 2021
regenerate with the latest gir
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks
get_charset()
signature and logic to properly returnboth the charset label and the UTF-8 boolean.