V3 — Update to node current LTS (20.12.2) and core dependencies

[mchv]

What does this change?

The associated changes update the action to run on node 20.12.2 as well as the core dependencies. Presented in a logical order:

• Commit 055e492 — Upgrade of node as version 16 has reached end of life, and Github actions should be upgraded.
• Commit c0ab742 — Update of core dependencies, notably guardian cdk, typescript, es-lint to the latest compatible version
• Commit af8b43f — Update of generated infrastructure code as a result of those dependencies update.
• Commit bc59741 — Remove an unused import
• Commit af4cc68 — Fix latest vulnerability, upgrading only package-lock.json

As the result of those upgrade:

• ✅ the typescript compiler, linter and tests are now running successfully (they are failing on main branch 🙀)
• ✅ all reported dependency vulnerabilities are fixed
• ✅ no warning when running the action
• ✅ next dependencies upgrade should be much easier
• 📝 all dependants who will update their workflow to version 3 of this action will have their infra benefit from the guardian cdk upgrade.

How to test?

I think that once this branch build, I should be able to reference it in a existing action and verify that it works before we release a version 3, but I am not certain.

How can we measure success?

• The action is running on a supported runtime
• 9 open security vulnerabilities all fixed

Linkage

Fixes #38

[mchv]

Ok, I think the workflow files need to be upgraded as well to run fine.

[mchv]

This now depends on https://github.com/guardian/riffraff-platform/pull/120

[github-actions]

Deploy build 178 of deploy::actions-static-site-infra to CODE

All deployment options

• Deploy build 178 of deploy::actions-static-site-infra to CODE
• Deploy parts of build 178 to CODE by previewing it first
• What's on CODE right now?

---

From guardian/actions-riff-raff.

[github-actions]

Deploy build 252 of deploy::the-coolest-static-site to CODE

All deployment options

• Deploy build 252 of deploy::the-coolest-static-site to CODE
• Deploy parts of build 252 to CODE by previewing it first
• What's on CODE right now?

---

From guardian/actions-riff-raff.

[NovemberTang]

We (me and @akash1810 ) tested this PR against galaxies, and found a few bits that are broken. Potentially there's some gaps in our CI here, but I think it makes sense to merge these in smaller chunks. We'll have another go at this later in the week.

[mchv]

@NovemberTang I think the main issue, was the same one I experienced on guardian/actions-read-private-repos#8. I will rebase and add missing bits.

[mchv]

Regarding the changes of ef06d4c we move from ts-node to tsx due to TypeStrong/ts-node#2094. Without that switch, cdk command will fail.

[emdash-ie]

I tested this on https://github.com/guardian/content-pipeline-docs/pull/10, but unfortunately the build failed:

Error: ReferenceError: module is not defined
Error: module is not defined
Error: Process completed with exit code 1.

[mchv]

@emdash-ie Yes there still an issue because of this esbuild change of behaviour.

You will notice in the change the cjs shim which is the documented workaround about the issue. Unfortunately this is not enough for some cjs modules in node such as child_processs, and so we need another workaround to transform calls to those modules.

We can't either switch to ncc because of this specific issue which has no workaround as far as I am aware.

[Jakeii]

I think the issue @emdash-ie mentioned is coming from the use of module here, it's not available in esmm modules and it's not getting converted.

https://2ality.com/2022/07/nodejs-esm-main.html

[bryophyta]

good call! I've tried this out as I'm working on some stuff for 10% time that requires actions-static-site. I made the changes in a branch and opened a PR into this branch: #39

although I also had to make a change to the tsconfig in order to get tsc to work. I think this was a pre-existing issue, but I'm not super confident with module resolution etc. in TS so would appreciate any perspectives on this 🙏

[emdash-ie]

I updated https://github.com/guardian/content-pipeline-docs/pull/10 to use the latest commit from this branch in https://github.com/guardian/content-pipeline-docs/pull/10/commits/dbdb9cb0e4909631a3ca3a15e98862dda74cc41e. The resulting build succeeded (after a false start due to a missing repository topic)! I then deployed this build successfully and the resulting site looks good.

[emdash-ie]

This looks good to me! I'm not super knowledgeable about the javascript module changes, but I'm satisfied that it's working based on my testing above.

[mchv]

@emdash-ie Great! Ok let's merge this and fix any issue we may find on this v3