Delete article-aside-adverts as it's no longer used (#1733)

guardian · Jan 10, 2025 · 627e730 · 627e730
1 parent a88e57f
commit 627e730
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 267 deletions.
diff --git a/.changeset/cuddly-parrots-fly.md b/.changeset/cuddly-parrots-fly.md
@@ -0,0 +1,5 @@
+---
+'@guardian/commercial': minor
+---
+
+Delete article-aside-adverts as it's no longer used
diff --git a/src/init/consented/dynamic-ad-slots.ts b/src/init/consented/dynamic-ad-slots.ts
@@ -1,4 +1,3 @@
-import { init as initArticleAsideAdverts } from '../../insert/article-aside-adverts';
 import { initCommentsExpandedAdverts } from '../../insert/comments-expanded-advert';
 import { init as initFootballRightAds } from '../../insert/fixures';
 import { init as initHighMerch } from '../../insert/high-merch';
@@ -13,7 +12,6 @@ type Modules = Array<[`${string}-${string}`, () => Promise<unknown>]>;
 const dynamicAdSlotModules: Modules = [
 	['cm-mobileSticky', initMobileSticky],
 	['cm-highMerch', initHighMerch],
-	['cm-articleAsideAdverts', initArticleAsideAdverts],
 	['cm-articleBodyAdverts', initArticleBodyAdverts],
 	['cm-liveblogAdverts', initLiveblogAdverts],
 	['cm-commentsExpandedAdverts', initCommentsExpandedAdverts],

diff --git a/src/init/consented/static-ad-slots.ts b/src/init/consented/static-ad-slots.ts
@@ -54,7 +54,6 @@ const decideAdditionalSizes = (adSlot: HTMLElement): SizeMapping => {
  * Static ad slots that were rendered on the page by the server are collected here.
  *
  * For dynamic ad slots that are created at runtime, see:
- *  - article-aside-adverts
  *  - article-body-adverts
  *  - high-merch
  */

diff --git a/src/insert/article-aside-adverts.spec.ts b/src/insert/article-aside-adverts.spec.ts
diff --git a/src/insert/article-aside-adverts.ts b/src/insert/article-aside-adverts.ts
diff --git a/src/insert/high-merch.ts b/src/insert/high-merch.ts
@@ -6,6 +6,8 @@ import fastdom from '../lib/fastdom-promise';
  * Initialise merchandising-high ad slot on Frontend rendered content
  *
  * On DCR, these ad slots are server side rendered
+ *
+ * Revisit whether this code is needed once galleries have been migrated to DCR
  */
 export const init = (): Promise<void> => {
 	if (commercialFeatures.highMerch) {