Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update husky command in prepare script #1756

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Jan 21, 2025

What does this change?

Updates prepare script from husky install to husky

Why?

husky install is deprecated

Screenshot 2025-01-21 at 11 12 34

See https://github.com/typicode/husky/releases/tag/v9.0.1

Copy link

changeset-bot bot commented Jan 21, 2025

⚠️ No Changeset found

Latest commit: 5271745

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cemms1 cemms1 changed the title Use husky init rather than husky install Use husky rather than husky install Jan 21, 2025
@cemms1 cemms1 changed the title Use husky rather than husky install Update husky command in prepare script Jan 21, 2025
@cemms1 cemms1 marked this pull request as ready for review January 21, 2025 11:18
@cemms1 cemms1 requested a review from a team as a code owner January 21, 2025 11:18
Copy link
Contributor

Ad load time test results

For consented, top-above-nav took on average 4266ms to load.
For consentless, top-above-nav took on average 2846ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@cemms1 cemms1 merged commit 50b02ec into main Jan 21, 2025
14 checks passed
@cemms1 cemms1 deleted the cemms1/fix-husky-command branch January 21, 2025 11:25
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @cemms1 1 minute and 48 seconds ago) Please check your changes!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants